Skip to content

fix(core): strip template wrapper before linting composition files#111

Merged
miguel-heygen merged 1 commit intomainfrom
fix/lint-template-stripping
Mar 28, 2026
Merged

fix(core): strip template wrapper before linting composition files#111
miguel-heygen merged 1 commit intomainfrom
fix/lint-template-stripping

Conversation

@miguel-heygen
Copy link
Copy Markdown
Collaborator

@miguel-heygen miguel-heygen commented Mar 28, 2026

Summary

  • Composition HTML files are always wrapped in <template id="..."> tags
  • The linter was checking the raw HTML including the template wrapper, causing false positives:
    • missing-composition-id on files that have it inside <template>
    • missing-dimensions on files that have data-width/data-height inside <template>
  • Fix: strip <template> wrapper before linting, matching how the runtime and preview server handle these files

Test plan

  • Added test: strips <template> wrapper before linting composition files
  • All 345 existing tests pass
  • Verify lint panel no longer shows false positives for composition files

🤖 Generated with Claude Code

@miguel-heygen miguel-heygen force-pushed the studio/8-cli-render-fixes branch from 808a061 to 0641f42 Compare March 28, 2026 05:18
@miguel-heygen miguel-heygen force-pushed the fix/lint-template-stripping branch 2 times, most recently from cd6ed65 to e0e2513 Compare March 28, 2026 05:36
@miguel-heygen Graphite App
Copy link
Copy Markdown
Collaborator Author

miguel-heygen commented Mar 28, 2026 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@miguel-heygen miguel-heygen mentioned this pull request Mar 28, 2026
Merged
4 tasks
@miguel-heygen miguel-heygen force-pushed the studio/8-cli-render-fixes branch from 0641f42 to 479883a Compare March 28, 2026 05:43
@miguel-heygen miguel-heygen force-pushed the fix/lint-template-stripping branch from e0e2513 to 83401f3 Compare March 28, 2026 05:43
@miguel-heygen miguel-heygen force-pushed the studio/8-cli-render-fixes branch from 479883a to afd329d Compare March 28, 2026 05:46
@miguel-heygen miguel-heygen force-pushed the fix/lint-template-stripping branch from 83401f3 to 35505d2 Compare March 28, 2026 05:46
@miguel-heygen miguel-heygen force-pushed the studio/8-cli-render-fixes branch from afd329d to 48573b0 Compare March 28, 2026 05:49
@miguel-heygen miguel-heygen force-pushed the fix/lint-template-stripping branch from 35505d2 to cdb6471 Compare March 28, 2026 05:50
@miguel-heygen miguel-heygen force-pushed the studio/8-cli-render-fixes branch 2 times, most recently from da8d3e2 to 758f6f4 Compare March 28, 2026 05:55
@miguel-heygen miguel-heygen force-pushed the fix/lint-template-stripping branch 2 times, most recently from 0922f20 to e2c84ac Compare March 28, 2026 05:58
@miguel-heygen miguel-heygen force-pushed the studio/8-cli-render-fixes branch from 758f6f4 to 2e00ae8 Compare March 28, 2026 06:20
@miguel-heygen miguel-heygen force-pushed the fix/lint-template-stripping branch from e2c84ac to d4f502a Compare March 28, 2026 06:21
@miguel-heygen miguel-heygen changed the base branch from studio/8-cli-render-fixes to graphite-base/111 March 28, 2026 06:40
This was referenced Mar 28, 2026
Merged
Merged
@miguel-heygen Graphite App
Copy link
Copy Markdown
Collaborator Author

miguel-heygen commented Mar 28, 2026 •
edited
Loading

Merge activity

@miguel-heygen miguel-heygen force-pushed the fix/lint-template-stripping branch 4 times, most recently from a762f46 to c741fd5 Compare March 28, 2026 17:47
This was referenced Mar 28, 2026
Merged
Closed
Merged
Merged
@miguel-heygen miguel-heygen force-pushed the fix/lint-template-stripping branch 2 times, most recently from 0175c77 to 910d51b Compare March 28, 2026 19:23
@miguel-heygen miguel-heygen changed the base branch from graphite-base/111 to studio/8-cli-render-fixes March 28, 2026 19:23
@miguel-heygen miguel-heygen force-pushed the studio/8-cli-render-fixes branch from 268cf0d to 56cd94f Compare March 28, 2026 19:32
@miguel-heygen miguel-heygen force-pushed the fix/lint-template-stripping branch from 910d51b to 7085ca1 Compare March 28, 2026 19:32
@miguel-heygen miguel-heygen force-pushed the studio/8-cli-render-fixes branch from 56cd94f to c073a4b Compare March 28, 2026 19:37
@miguel-heygen miguel-heygen force-pushed the fix/lint-template-stripping branch from 7085ca1 to 3b76ee2 Compare March 28, 2026 19:37
@miguel-heygen miguel-heygen force-pushed the studio/8-cli-render-fixes branch from c073a4b to 26ec4ef Compare March 28, 2026 19:42
@miguel-heygen miguel-heygen force-pushed the fix/lint-template-stripping branch from 3b76ee2 to 0a1a093 Compare March 28, 2026 19:42
@miguel-heygen miguel-heygen force-pushed the studio/8-cli-render-fixes branch from 26ec4ef to f89e26d Compare March 28, 2026 19:47
@miguel-heygen miguel-heygen force-pushed the fix/lint-template-stripping branch from 0a1a093 to d551be4 Compare March 28, 2026 19:47
@miguel-heygen miguel-heygen force-pushed the studio/8-cli-render-fixes branch from f89e26d to ee98aca Compare March 28, 2026 19:52
@miguel-heygen miguel-heygen force-pushed the fix/lint-template-stripping branch from d551be4 to 2a2a676 Compare March 28, 2026 19:52
@miguel-heygen miguel-heygen force-pushed the studio/8-cli-render-fixes branch from ee98aca to d5f3bef Compare March 28, 2026 19:57
@miguel-heygen miguel-heygen force-pushed the fix/lint-template-stripping branch from 2a2a676 to 87a108d Compare March 28, 2026 19:57
@miguel-heygen miguel-heygen force-pushed the studio/8-cli-render-fixes branch from d5f3bef to 80c0932 Compare March 28, 2026 19:59
@miguel-heygen miguel-heygen force-pushed the fix/lint-template-stripping branch from 87a108d to 126b1b6 Compare March 28, 2026 19:59
@miguel-heygen miguel-heygen force-pushed the studio/8-cli-render-fixes branch from 80c0932 to aa0489c Compare March 28, 2026 20:09
@miguel-heygen miguel-heygen force-pushed the fix/lint-template-stripping branch from 126b1b6 to 327d0c5 Compare March 28, 2026 20:09
@miguel-heygen miguel-heygen force-pushed the studio/8-cli-render-fixes branch 2 times, most recently from aec2f11 to 24c13e0 Compare March 28, 2026 20:29
@miguel-heygen miguel-heygen force-pushed the fix/lint-template-stripping branch from 327d0c5 to 348d260 Compare March 28, 2026 20:29
@miguel-heygen miguel-heygen changed the base branch from studio/8-cli-render-fixes to graphite-base/111 March 28, 2026 20:49
@miguel-heygen miguel-heygen force-pushed the fix/lint-template-stripping branch from 348d260 to 91c73ec Compare March 28, 2026 20:49
@graphite-app graphite-app bot changed the base branch from graphite-base/111 to main March 28, 2026 20:49
@miguel-heygen @claude
fix(core): strip template wrapper and reduce false positives in linter
c807643 
- Strip <template> wrapper before linting composition files — compositions
  are always wrapped in <template id="..."> tags, causing false positives
  for missing data-composition-id and dimensions
- Downgrade timed_element_missing_visibility_hidden from warning to info —
  most HyperFrames compositions use GSAP to manage visibility via opacity
  animations, not class="clip"
- Skip visibility check for composition roots and hosts (data-composition-id,
  data-composition-src) — the runtime manages their lifecycle
- Accept opacity:0 as a valid initial hidden state alongside visibility:hidden
- Add "info" severity level to lint types

Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
@miguel-heygen miguel-heygen force-pushed the fix/lint-template-stripping branch from 91c73ec to c807643 Compare March 28, 2026 20:49
@miguel-heygen miguel-heygen merged commit fecd4c8 into main Mar 28, 2026
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vanceingalls vanceingalls vanceingalls approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@miguel-heygen @vanceingalls